Open
Conversation
- Possibility to enable / disable payment rounding - Possibility to change the specific integers of said rounding - Config options for both to allow the server owner the most flexibility - Commented out a boolean that wasn't used in SellTask - First attempt at trying to pre-index the common variables so they don't get setup each function call.
- Changed the static 2 decimal rounding in ChestShop to dynamic rounding same as in SellTask. Both use the same Config options to not cluster the config.
Contributor
Author
|
To all developers, yes I know I could've used a helper class to implement the rounding up in a more fashioned way. But currently it would be a little bit overkill and for 2 implementations, a little bit unnecessary. |
WaterArchery
requested changes
Aug 22, 2024
Owner
WaterArchery
left a comment
WaterArchery
left a comment
There was a problem hiding this comment.
Please don't remove existing features like isSellWithLore and notifyOnUnsellable. NotSellingNot and notifyOnUnsellable seems identical.
Also please use camel case rule while naming variables.
Owner
|
Thank you for your contrubution. Please fix these. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1st PR:
Feature Suggestion:
2nd PR:
Bug Fix:
3rd PR: