fix(scanArea): prevent crash when area feature has no name/key#1225
Merged
Conversation
Guard the scan area search filter against features missing a properties.key (which happens when a scan area polygon has no name set), instead of throwing TypeError: Cannot read properties of undefined (reading 'toLowerCase'). Also fixes a longstanding typo (geoJsonFilName / geoJsonFilname -> geoJsonFileName) in the multi-domain example config and docs.
There was a problem hiding this comment.
Pull request overview
This PR hardens the scan-area GeoJSON filtering logic to avoid a runtime crash when a scan-area feature lacks a properties.key, and it corrects a typo in the multi-domain example configs/docs so they match the actual geoJsonFileName setting used by the server config loader.
Changes:
- Guard scan-area search filtering against missing
properties.keyto preventtoLowerCase()crashes. - Fix
geoJsonFilName/geoJsonFilenametypos togeoJsonFileNamein multi-domain example configs and documentation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/features/scanArea/ScanAreaTile.jsx | Adds a fallback when filtering features by properties.key during search. |
| config/multi-domain-example/README.md | Updates docs to reference geoJsonFileName (and related wording). |
| config/multi-domain-example/local-orangemap.json | Renames the example config key to geoJsonFileName. |
| config/multi-domain-example/local-applemap.json | Renames the example config key to geoJsonFileName. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Mygod
added a commit
that referenced
this pull request
Jul 5, 2026
#1226) * fix(scanArea): prevent crash when area feature has no name/key Guard the scan area search filter against features missing a properties.key (which happens when a scan area polygon has no name set), instead of throwing TypeError: Cannot read properties of undefined (reading 'toLowerCase'). Also fixes a longstanding typo (geoJsonFilName / geoJsonFilname -> geoJsonFileName) in the multi-domain example config and docs. * fix: copilot comments --------- Co-authored-by: turtlesocks-bot <turtlesocks-bot@users.noreply.github.com> Co-authored-by: PJ0tter <pjorritsma@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard the scan area search filter against features missing a properties.key (which happens when a scan area polygon has no name set), instead of throwing TypeError: Cannot read properties of undefined (reading 'toLowerCase').
Also fixes a longstanding typo (geoJsonFilName / geoJsonFilname -> geoJsonFileName) in the multi-domain example config and docs.