Skip to content

Fix logic bug in loading non-clustered elements #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mygod merged 4 commits into from
Dec 15, 2025
Merged

Fix logic bug in loading non-clustered elements #1161

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aba3a8a
chore(release): v1.0.0-develop.1 [skip ci]
semantic-release-bot Sep 24, 2025
b7aee4b
Fix logic bug in loading non-clustered elements
ComplementaryPogo Nov 18, 2025
a114be1
Merge remote-tracking branch 'origin/develop' into ComplementaryPogo/…
Mygod Nov 25, 2025
a60d819
Merge branch 'develop' into ComplementaryPogo/main
Mygod Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/map/components/Clustering.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export function Clustering({ category, children }) {
return (
<>
<GeoJSON ref={featureRef} data={null} pointToLayer={createClusterIcon} />
{children.length > rules.forcedLimit || userCluster
{(children.length > rules.forcedLimit || userCluster) && !IGNORE_CLUSTERING.has(category)

Copilot AI Nov 25, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix on line 150 prevents filtering children for IGNORE_CLUSTERING categories, but there's an inconsistency: if userCluster is true for a category in IGNORE_CLUSTERING, line 85 would still create a superCluster instance, causing cluster icons to be rendered via the GeoJSON component (line 149), while line 150 now renders all individual children. This would result in both cluster markers and individual markers being displayed simultaneously.

Consider also checking !IGNORE_CLUSTERING.has(category) at line 85 to prevent cluster creation entirely for these categories:

if ((limitHit || userCluster) && !IGNORE_CLUSTERING.has(category)) {

Copilot uses AI. Check for mistakes.
? children.filter((x) => x && markers.has(x.key))
: children}
{limitHit && (
Expand Down
Loading