-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for typescript via JSDoc #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Various notes and questions, most of which are of exceedingly low importance.
Might want to check out the rendered version at https://github.com/WardBrian/tinystan/blob/start-js-docs/docs/languages/js.md to see how you like it; I think it could use more whitespace between sections, and/or more indentation--the various blocks describing the StanModel
methods & their parameters, in particular, tend to run into each other--but I'm not sure whether you care or how easy that would be to fix with this tooling.
Overall though I think this is a good addition.
* @property {number} [num_paths=4] The number of individual paths to run. | ||
* @property {string | StanVariableInputs | string[] | StanVariableInputs[]} [inits=""] | ||
* The initial values for the algorithm. If an array, must have length `num_paths`. | ||
* @property {number | null} [seed] The seed for the random number generator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this default to null
(or undefined
?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, but the rendering for null
is also pretty bad
https://brianward.dev/tinystan/latest/languages/js.html