Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for typescript via JSDoc #45

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Add documentation for typescript via JSDoc #45

merged 5 commits into from
Nov 15, 2024

Conversation

WardBrian
Copy link
Owner

@WardBrian WardBrian commented Nov 13, 2024

@WardBrian WardBrian added the documentation Improvements or additions to documentation label Nov 13, 2024
Copy link

@jsoules jsoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various notes and questions, most of which are of exceedingly low importance.

Might want to check out the rendered version at https://github.com/WardBrian/tinystan/blob/start-js-docs/docs/languages/js.md to see how you like it; I think it could use more whitespace between sections, and/or more indentation--the various blocks describing the StanModel methods & their parameters, in particular, tend to run into each other--but I'm not sure whether you care or how easy that would be to fix with this tooling.

Overall though I think this is a good addition.

clients/typescript/package.json Show resolved Hide resolved
clients/typescript/package.json Show resolved Hide resolved
docs/languages.rst Show resolved Hide resolved
docs/languages/js.md Show resolved Hide resolved
clients/typescript/doc/language-doc.hbs Outdated Show resolved Hide resolved
clients/typescript/src/types.ts Outdated Show resolved Hide resolved
clients/typescript/src/types.ts Outdated Show resolved Hide resolved
* @property {number} [num_paths=4] The number of individual paths to run.
* @property {string | StanVariableInputs | string[] | StanVariableInputs[]} [inits=""]
* The initial values for the algorithm. If an array, must have length `num_paths`.
* @property {number | null} [seed] The seed for the random number generator.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this default to null (or undefined?)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, but the rendering for null is also pretty bad

clients/typescript/src/types.ts Outdated Show resolved Hide resolved
clients/typescript/src/types.ts Outdated Show resolved Hide resolved
@WardBrian WardBrian merged commit fe451c1 into main Nov 15, 2024
17 checks passed
@WardBrian WardBrian deleted the start-js-docs branch November 15, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants