Test#33
Open
WangGuangxin wants to merge 7 commits into
Open
Conversation
…cpp scaffold + table-format/UT wiring) Co-Authored-By: Aime <aime@bytedance.com> Change-Id: I014041fa422814612b3034af39e966e995ac655c
…fig (batchsize default + shuffle.check.ratio) Co-Authored-By: Aime <aime@bytedance.com> Change-Id: I00ef468c3b038b61129b6448f52ee7aac044f5b3
…Api (sequence/format_number/map_from_arrays + first/last row_constructor); native validator scaffold notes Co-Authored-By: Aime <aime@bytedance.com> Change-Id: Id52914337632ca8efea73015a4a20913301e6fd0
…rted vs deferred) in backends-bolt/README Co-Authored-By: Aime <aime@bytedance.com> Change-Id: Icc9dcd14c1fddf0b24968272b05af46b05248148
|
Run Gluten Clickhouse CI on x86 |
…ve bridge from cpp/velox (no committed copy) + conan bolt::bolt / BOLT_HOME wiring + builddeps-boltbe.sh Co-Authored-By: Aime <aime@bytedance.com> Change-Id: I790a9c7fa18cda05a34bf0e24df697911db568e1
|
Run Gluten Clickhouse CI on x86 |
…d PR: conan bolt::bolt + ENABLE_BOLT/bolt.CMakeLists.cmake + cpp/conanfile.py + build_bolt_arrow + bolt Dockerfiles (keep thin codegen, no committed cpp/bolt copy) Co-Authored-By: Aime <aime@bytedance.com> Change-Id: I818dc39b31ef2672c64f57eeee9c663e2f3727de
|
Run Gluten Clickhouse CI on x86 |
…cific sources
The substrait conversion layer (SubstraitToVeloxPlan/Expr/Validator,
SubstraitParser, ...) is the most engine-coupled part of the Velox bridge,
and Bolt routinely diverges from upstream Velox there at the interface
level, beyond what the sed-driven codegen can absorb.
Add a visible, hand-editable override directory at cpp/bolt/substrait/:
* dev/gen-bolt-cpp.sh: after the namespace/include substitutions and
before emitting the generated CMakeLists, overlay every C/C++ source
found under cpp/bolt/substrait/<relpath> onto
${BOLT_GEN_DIR}/substrait/<relpath>. The override copy is NOT
sed-processed (hand-written files are already authored in
bytedance::bolt / bolt/ form). Logs one line per overridden file and
reports the count in the summary.
* The generated CMakeLists source list (extracted from cpp/velox/
CMakeLists.txt VELOX_SRCS) is keyed by relative path, so the overlaid
file takes the slot of the generated one -- no duplicate compilation.
* cpp/bolt/CMakeLists.txt is unchanged: overlay-before-add_subdirectory
is sufficient.
* cpp/bolt/substrait/ ships only README.md + .gitkeep; no actual
override sources are committed yet.
* cpp/bolt/README.md, backends-bolt/README.md, docs/Bolt.md document
the mechanism and when to use it.
Default Velox build path is untouched.
Validated locally with bash -n syntax check and a dry-run codegen: a
dummy override at cpp/bolt/substrait/TypeUtils.h was overlaid onto the
generated tree byte-for-byte and reported as
override: substrait/TypeUtils.h <- cpp/bolt/substrait/TypeUtils.h
hand-written overrides applied : 1
residue check : 0/0
Dummy file removed before commit.
Generated-by: Aime aime-prod
Co-Authored-By: Aime <aime@bytedance.com>
Change-Id: I4881b25a258c00023d8bd59f6ea4d59b5d77ba39
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.