[fix] disable gluten internal 'round' function and rely on Bolt's RoundFunction implementation#18
Open
markjin1990 wants to merge 1 commit into
Conversation
markjin1990
force-pushed
the
disable-gluten-round-func
branch
from
March 25, 2026 19:14
5ec2e7b to
9b2eeda
Compare
|
@markjin1990 would you like to merge this pr recently ? |
… Bolt-side "round" function instead * fix 'round' test result for round(3.1415f, 3) * Enable bolt for negative scale * Fix unit test * Revert "Add unit tests" * [fix] disable gluten internal 'round' function and rely on Bolt's RoundFunction implementation * Add unit tests See merge request: !1752
markjin1990
force-pushed
the
disable-gluten-round-func
branch
from
April 8, 2026 19:16
9b2eeda to
145cec3
Compare
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
round(113.237209, 6)returning 113.23720900000001...How was this patch tested?
round.Was this patch authored or co-authored using generative AI tooling?
No