Update msdial5_formatter.py #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I understand, 'scan = int(record["Alignment ID"]) +1 ' was written because the early version MSDIAL 5 counted their Alignment ID from 0. However, now its GNPS2 export module starts Alignment ID from 1, so this is making a bug.
Contributor
|
Can you provide an example of it so we can test it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I understand, 'scan = int(record["Alignment ID"]) +1 ' was written because the early version MSDIAL 5 counted their Alignment ID from 0. However, now its GNPS2 export module starts Alignment ID from 1, so this is making a bug.