Skip to content

Smaller chunk size #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ztorage wants to merge 2 commits into
base: wallaroo-main
Choose a base branch
from
+1 −1
Open

Smaller chunk size #4

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ea2e2f
Smaller chunk size
ztorage Mar 6, 2025
fe3d4ef
32 megabytes! Should be enough for everyone
ztorage Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion s3/src/bucket.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ use crate::utils::error_from_response_data;
use http::header::HeaderName;
use http::HeaderMap;

pub const CHUNK_SIZE: usize = 268_435_456; // 256 Mebibytes (8 wasn't enough), min is 5 (5_242_880);
pub const CHUNK_SIZE: usize = 16_777_216; // 16 Mebibytes (8 wasn't enough), min is 5 (5_242_880);
Copy link

@jasonmccampbell jasonmccampbell Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block size is needed to support uploading 70B models since S3 protocol only allows a max of 10k blocks.


const DEFAULT_REQUEST_TIMEOUT: Option<Duration> = Some(Duration::from_secs(60));

Expand Down