Skip to content

remove unsound MaybeUninitSlice::from_init_mut and useless `...::fr… #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2020
Merged

remove unsound MaybeUninitSlice::from_init_mut and useless `...::fr… #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions src/ext/slice_ext.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,6 @@ pub trait MaybeUninitSlice:
/// [inv]: core::mem#initialization-invariant
/// [`MaybeUninit::assume_init`]: core::mem::MaybeUninit::assume_init
unsafe fn assume_init_mut(&mut self) -> &mut [Self::InitItem];

/// Create self from initialized slice
fn from_init(init: &[Self::InitItem]) -> &Self;

/// Create self from initialized slice
fn from_init_mut(init: &mut [Self::InitItem]) -> &mut Self;
}

impl<T> Slice for [T] {
Expand Down Expand Up @@ -223,22 +217,4 @@ impl<T> MaybeUninitSlice for [MaybeUninit<T>] {
// `uninit` state
&mut *(self as *mut [MaybeUninit<T>] as *mut [T])
}

#[inline]
fn from_init(init: &[Self::InitItem]) -> &Self {
// ## Safety
//
// `MaybeUninit<T>` is guaranteed to have the same ABI as `T`, so
// it's safe to cast `&[T]` to `&[MaybeUninit<T>]`
unsafe { &*(init as *const [T] as *const [MaybeUninit<T>]) }
}

#[inline]
fn from_init_mut(init: &mut [Self::InitItem]) -> &mut Self {
// ## Safety
//
// `MaybeUninit<T>` is guaranteed to have the same ABI as `T`, so
// it's safe to cast `&mut [T]` to `&mut [MaybeUninit<T>]`
unsafe { &mut *(init as *mut [T] as *mut [MaybeUninit<T>]) }
}
}