-
Notifications
You must be signed in to change notification settings - Fork 88
Fix UI lobby profile editor #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix UI lobby profile editor #1056
Conversation
|
Всё я пошёл |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
WalkthroughРеализована функция управления неиспользуемыми загрузками (loadouts) в редакторе профиля персонажей. Добавлены UI элементы для отображения и удаления неподходящих загрузок, расширена логика обновления состояния загрузок с проверкой требований, и реализовано распространение видимости загрузок через иерархию компонентов. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In `@Content.Client/Lobby/UI/HumanoidProfileEditor.xaml`:
- Around line 199-214: The LoadoutsRemoveUnusableButton currently has an English
placeholder ("You shouldn't see this"); change its initial Text to a neutral
value (e.g., empty string or a localized placeholder) in the XAML so the user
never sees the English message, and ensure the UpdateLoadoutsRemoveButton method
is responsible for populating the final label at runtime for
LoadoutsRemoveUnusableButton.
In `@Content.Client/Lobby/UI/HumanoidProfileEditor.xaml.cs`:
- Around line 2406-2441: CheckAndHideTabs only hides tabs but never restores
them; change the logic so it sets visibility explicitly based on current content
(i.e., call container.SetTabVisible(tabId, !shouldHide) instead of only hiding),
ensure CheckNestedContainer still recurses into nested NeoTabContainer and
returns whether it has any visible child controls, and update HasVisibleTraits
to reflect current selector.Visible state; also wire a call to
CheckAndHideTabs(TraitsTabs) (or the same updater) whenever filters/state that
affect trait visibility (e.g., "show unusable") change so tabs are re-evaluated
and shown again when traits become visible.
- Around line 2482-2503: The UpdateLoadoutsRemoveButton method sets the wrong
style class on LoadoutsRemoveUnusableButton causing OpenRight to be applied
instead of OpenLeft; update both branches in UpdateLoadoutsRemoveButton to
RemoveStyleClass(StyleBase.ButtonOpenLeft) /
AddStyleClass(StyleBase.ButtonOpenLeft) as appropriate (replace references to
StyleBase.ButtonOpenRight with StyleBase.ButtonOpenLeft) so the button matches
the XAML and avoids duplicate/conflicting rounded-corner classes.
- Around line 2457-2479: После удаления лодаутов в TryRemoveUnusableLoadouts
Profile обновляется, но не вызываются методы, которые обновляют превью и флаг
"dirty"; исправьте это, либо вызвав существующую общую логику (вызвать
OnLoadoutsChange() после присвоения Profile), либо явно вызвать
ReloadProfilePreview() и ReloadClothes() и обновление состояния сохранения после
строки Profile = currentProfile; чтобы превью и кнопки сохранения
синхронизировались с новым Profile.
|
Там если что в процессе всё |
|
Сделаю-ка я драфт |
Описание PR
Небольшой фикс разного рода UI в редакторе персонажа:
Медиа
Список
Лоадауты:

Трейты:

Изменения
🆑 Myaflic