Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that tags do not contain control characters #369

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Conversation

domenic
Copy link
Collaborator

@domenic domenic commented Mar 19, 2025

/cc @robertlin-chromium @nhiroki

The Structured Fields specification already required this but the specification was not properly failing at parse time.

@domenic domenic requested a review from nhiroki March 19, 2025 04:58
Copy link

Preview:

Copy link
Collaborator

@nhiroki nhiroki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@domenic domenic merged commit 8c38a2e into main Mar 21, 2025
2 checks passed
@domenic domenic deleted the tag-string-type branch March 21, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants