-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prototype: pytorch base learner #4660
prototype: pytorch base learner #4660
Conversation
update https://github.com/VowpalWabbit/vowpal_wabbit/blob/master/ThirdPartyNotices.txt if you are planning on merging |
int num_layers = 3; | ||
int hidden_layer_size = 20; | ||
int mini_batch_size = 10; | ||
new_options.add(make_option("dnn", use_dnn).keep().necessary().help("Fully connected deep neural network base learner.")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we mark them as experimental()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep.
Got it. |
Makes sense. |
To be re-opened in the future |
Current todo
Current bugs
Post MVP Wish list
Debugging Notes:
When building debug configuration in windows, and using system dependencies, use the debug version of libtorch libraries. This is because release version of your app will be ABI incompatible with debug version of libtorch and vice-versa leading to very odd errors. This is why std cpp types should not be used in library interfaces!