fix: Build break on Ubuntu 2004

The code to generate bad namespaces in examples was interacting poorly with auto.
VowpalWabbit · Feb 15, 2024 · bc710dd · bc710dd
1 parent c2c75e3
commit bc710dd
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/vowpalwabbit/fb_parser/tests/read_span_tests.cc b/vowpalwabbit/fb_parser/tests/read_span_tests.cc
@@ -178,13 +178,15 @@ Offset<fb::ExampleCollection> create_bad_ns_root_collection(
 {
   if VW_STD17_CONSTEXPR (multiline)
   {
-    auto inner_examples = {create_bad_ns_root_multiex(builder, w, ns_fac)};
+    // using "auto" here breaks the code coverage build due to template substitution failure
+    std::vector<Offset<fb::MultiExample>> inner_examples = {create_bad_ns_root_multiex(builder, w, ns_fac)};
     return fb::CreateExampleCollection(builder, builder.CreateVector(std::vector<Offset<fb::Example>>()),
         builder.CreateVector(inner_examples), multiline);
   }
   else
   {
-    auto inner_examples = {create_bad_ns_root_example(builder, w, ns_fac)};
+    // using "auto" here breaks the code coverage build due to template substitution failure
+    std::vector<Offset<fb::Example>> inner_examples = {create_bad_ns_root_example(builder, w, ns_fac)};
     return fb::CreateExampleCollection(builder, builder.CreateVector(inner_examples),
         builder.CreateVector(std::vector<Offset<fb::MultiExample>>()), multiline);
   }