-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add menu positioning settings #304
Open
siimha
wants to merge
10
commits into
master
Choose a base branch
from
303_menu_positioning_settings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
765526f
Add menu positioning settings
siimha d46bc68
Change positioning titles
siimha 3cf87b3
Change footer & header to left when menu open
siimha 17ac964
Merge branch 'master' into 303_menu_positioning_settings
521349f
Mobile menu view settings button
c58c179
Variable and function name fixes
5a31cb2
I18n translations added
dc8812e
Merge branch 'master' into 303_menu_positioning_settings
404f08e
Fixed bugs from prevoius comments by reviewer
44e9f19
Removed unneccecary commas.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
{% if editmode %} | ||
<button class="mobile-menu-button-settings"></button> | ||
{% endif %} | ||
|
||
{% editorjsblock %} | ||
<!-- Settings popover javascript. --> | ||
<script | ||
src="{{ site.static_asset_host }}/libs/edicy-tools/latest/edicy-tools.js" | ||
></script> | ||
|
||
<!-- Setings popover initiation. --> | ||
<script> | ||
var siteData = new Edicy.CustomData({ | ||
type: 'site', | ||
}); | ||
|
||
{% if site.data.mobile_menu_button_settings %} | ||
var valuesObj = {{ site.data.mobile_menu_button_settings | json }}; | ||
{% else %} | ||
var valuesObj = {}; | ||
{% endif %}; | ||
|
||
var mobileMenuSettingsButton = document.querySelector('.mobile-menu-button-settings'); | ||
|
||
var SettingsEditor = new Edicy.SettingsEditor(mobileMenuSettingsButton, { | ||
menuItems: [ | ||
{ | ||
"titleI18n": "menu_positioning", | ||
"type": "radio", | ||
"key": "menu_positioning", | ||
"list": [ | ||
{ | ||
"titleI18n": "fixed_in_header", | ||
"value": "" | ||
}, | ||
{ | ||
"titleI18n": "always_visible", | ||
"value": "always-visible" | ||
}, | ||
{ | ||
"titleI18n": "visible_when_scrolling_up", | ||
"value": "visible-when" | ||
} | ||
] | ||
}, | ||
], | ||
|
||
// Binded data object which should contain custom data object. | ||
values: valuesObj, | ||
|
||
// Style type the button. | ||
buttonStyle: 'default', | ||
// Title for the button. | ||
buttonTitleI18n: 'mobile_view_settings', | ||
|
||
commit: function(data) { | ||
siteData.set('mobile_menu_button_settings', data, { | ||
success: function() { | ||
window.location.reload(); | ||
} | ||
}); | ||
} | ||
}); | ||
</script> | ||
{% endeditorjsblock %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lisada ka tooltip nagu antud PRis.