DOC: Reduce suggested precision to zero after decimal places #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the default precision for temperature sensors and hot water availablility to zero.
When the temperature sensors have
Nonesuggested precision, you get long numbers when using Farenheit units e.g. "125.0006" due to the conversion from celsius. You really just don't need that many decimal places, so the default precision should be zero. e.g. "125F" or "50C".Likewise, for available hot water percentage. "84.2%" is too much precision. Can the human mind comprehend 1000 unique states of available hot water? Probably not. I think in this case it would actually be most useful to show liters or gallons of hot water remaining, but the Aquanta API does not report this data, so it should be left to the user to template thier own sensor for this purpose using their knowlege of the capacity of their device.