API: Reimplement WaterHeaterEntity operation modes to match Aquanta operation modes #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Homeassistant Core has deprecated the TEMP_CELSIUS constant. The new constant is an ENUM which collects all temp units together. Closes VolantisDev#66
The API returns the Aquanta Intelligence settings "less efficient", "efficient" and "most efficient" as a fraction of 1.
|
This sounds awesome, thanks for working on this! Happy to provide any testing or assistance needed. I've enabled repository actions on this PR so that ruff will run as changes are pushed. |
|
I've been running this feature from my fork for a few days now. Testing and feedback would be appreciated. |
carterbox
changed the title
|
Note that I haven't actually made any progress towards figuring out how to request the Aquanta API change control states, so these changes are mostly just to allow users to view the correct control mode when using the Thermostat Widget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Aquanta controller has 5 operational modes: Aquanta Intelligence, Thermostat Control, Time of Use, Manual Timer, and "Off". Where "Off" just disables the Aquanta controller, so the heater still heats water as if the Aquanta controller was not attached; it is thermostat controlled, just not the Aquanta's thermostat.
This PR reimplements the
WaterHeaterEntitystates to match these four operational states instead of trying to remap them to the states implemented for the genericWaterHeaterEntityofEco,Performance, andOff. WhereEcowas mapped to Aquanta Intelligence,Performancewas mapped to the emphemeral boost state, andOffis mapped to disabling the Aquanta controller (but doesn't actually turn off the water heater).This is a step toward being able to use the home assistant interface to switch between these operational modes.
Relies on #90