Skip to content

fix(word-cloud): improve animation config handling and add max #3938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(word-cloud): improve animation config handling and add max #3938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/vchart/src/series/word-cloud/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,10 @@ export class BaseWordCloudSeries<T extends IBaseWordCloudSeriesSpec = IBaseWordC
if (mark) {
const appearPreset = (this._spec?.animationAppear as IStateAnimateSpec<any>)?.preset;
const params = {
animationConfig: () => mark.getAnimationConfig()?.appear?.[0]
animationConfig: () => {
const config = mark.getAnimationConfig()?.appear;
return Array.isArray(config) ? config[0] : config;
}
};
mark.setAnimationConfig(
animationConfig(
Expand Down Expand Up @@ -420,6 +423,7 @@ export class BaseWordCloudSeries<T extends IBaseWordCloudSeriesSpec = IBaseWordC
shrink: this._wordCloudConfig.zoomToFit.shrink,
enlarge: this._wordCloudConfig.zoomToFit.enlarge,
minFontSize: this._wordCloudConfig.zoomToFit.fontSizeLimitMin,
maxFontSize: this._wordCloudConfig.zoomToFit.fontSizeLimitMax,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

底层没有支持这个配置，需要在算法层支持该配置

progressiveTime: this._wordCloudConfig.progressiveTime,
progressiveStep: this._wordCloudConfig.progressiveStep,
repeatFill: this._wordCloudConfig.zoomToFit.repeat
Expand Down