Only use name in field options if not empty (#1)

VirusTotal · Sep 12, 2024 · 034c888 · 034c888
1 parent 0a18445
commit 034c888
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/generator/generator.go b/generator/generator.go
@@ -289,7 +289,9 @@ func (g *Generator) getName(d desc.Descriptor) (name string) {
 	if ext, err := proto.GetExtension(d.GetOptions(), yara.E_MessageOptions); err == nil {
 		name = ext.(*yara.MessageOptions).GetName()
 	} else if ext, err := proto.GetExtension(d.GetOptions(), yara.E_FieldOptions); err == nil {
-		name = ext.(*yara.FieldOptions).GetName()
+		if ext.(*yara.FieldOptions).GetName() != "" {
+			name = ext.(*yara.FieldOptions).GetName()
+		}
 	} else if ext, err := proto.GetExtension(d.GetOptions(), yara.E_EnumOptions); err == nil {
 		name = ext.(*yara.EnumOptions).GetName()
 	}

diff --git a/pb/yara.proto b/pb/yara.proto
@@ -10,7 +10,9 @@ message ModuleOptions {
 }
 
 message FieldOptions {
+  // Name of the field in YARA rules. Ignored if empty.
   string name = 1;
+
   bool ignore = 2;
 }