Skip to content

feat: populating navigation item related #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

CodeVoyager
Copy link
Contributor

Ticket

#501

Summary

Taking into account contentTypesPopulate when rendering navigation

Test Plan

  • start the server
  • set contentTypesPopulate field in navigation
  • prepare internal content to have relational fields filled
  • render a navigation
  • navigation item's related field should be populated as expected

@CodeVoyager CodeVoyager added the bug Something isn't working label Jan 18, 2025
@CodeVoyager CodeVoyager requested a review from cyp3rius January 18, 2025 09:03
@CodeVoyager CodeVoyager self-assigned this Jan 18, 2025
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.04%. Comparing base (f8d3fcd) to head (82f50fd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #505   +/-   ##
=======================================
  Coverage   89.04%   89.04%           
=======================================
  Files          19       19           
  Lines         283      283           
  Branches       45       45           
=======================================
  Hits          252      252           
  Misses         30       30           
  Partials        1        1           
Flag Coverage Δ
unittest 89.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyp3rius cyp3rius force-pushed the fix/populating-navigation-related branch from e089e68 to 44f636e Compare January 23, 2025 12:39
@cyp3rius cyp3rius merged commit b3c30b8 into master Jan 23, 2025
3 checks passed
@cyp3rius cyp3rius deleted the fix/populating-navigation-related branch January 23, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants