Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fill from other locale #504

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

CodeVoyager
Copy link
Contributor

Ticket

#496

Summary

  • related field not being copied on fill
  • custom fields not being copied on fill
  • missing viewId on navigation copied from other locale

Test Plan

  • start the server
  • go to Navigation view
  • have a filled navigation from one locale, and empty for other locale
  • have internal items and additional fields on first locale
  • fill from other locale
  • all required info is copied from the source
  • remove a navigation item on newly created navigation
  • restore a navigation item on newly created navigation
  • save
  • refresh view

@CodeVoyager CodeVoyager added the bug Something isn't working label Jan 15, 2025
@CodeVoyager CodeVoyager requested a review from cyp3rius January 15, 2025 15:28
@CodeVoyager CodeVoyager self-assigned this Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.04%. Comparing base (40bf424) to head (f174ccc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #504   +/-   ##
=======================================
  Coverage   89.04%   89.04%           
=======================================
  Files          19       19           
  Lines         283      283           
  Branches       45       45           
=======================================
  Hits          252      252           
  Misses         30       30           
  Partials        1        1           
Flag Coverage Δ
unittest 89.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyp3rius cyp3rius merged commit f8d3fcd into master Jan 23, 2025
1 check passed
@cyp3rius cyp3rius deleted the fix/fill-from-other-locale-related branch January 23, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants