Skip to content

fix: use AccessControlUpgradeable #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

neutiyoo
Copy link

@neutiyoo neutiyoo commented Jan 9, 2025

This pull request includes several changes to upgrade the access control mechanism in various smart contracts and update dependencies in the package.json file. The most important changes include replacing AccessControl with AccessControlUpgradeable in multiple contracts and updating the OpenZeppelin contracts version.

Use AccessControlUpgradeable (or similar *Upgradeable contracts) for upgradeable contracts to ensure compatibility and proper initialization. Using AccessControl in an upgradeable context will result in uninitialized state, potential security risks, and failure to follow upgradeability patterns.

Access Control Upgrades:

Dependency Updates:

  • package.json: Updated @openzeppelin/contracts to version 5.1.0 and @openzeppelin/contracts-upgradeable to version 5.1.0.

@neutiyoo neutiyoo changed the title Fix/factory fix: use AccessControlUpgradeable Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant