- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the README in the MCs folder #483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @meg-gutshall,
Now I see what you mean by removing references to VC store. It wasn't clear on the issue. 😅
However, this PR is out of the scope from what has been proposed.
Can you please either:
- Remove the changes besides removing the references and create another issue & PR for updating the content, or
- Update your issue to "Update the README in the MCs folder", and mention the reasons of the update and the proposed solutions in the body
This will be benefit us to have a clear history of the changes in this repo. Thanks! ✨
✅ Deploy Preview for vc-community-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @adiati98! I implemented the changes you requested by updating the issue. It looks like when I pulled in the changes, my IDE auto-formatted all the Docusaurus front matter. I'm gonna have to figure out how to get around that... @danieltott, any ideas? |
@meg-gutshall so it looks like the issue is that it reformatted the frontmatter to single quotes. You might have to change a setting in your VSCode if that's what you're using:Open Settings (Ctrl+Shift+P → Preferences: Open Settings (JSON))
But also, I don't necessarily disagree with this change. We should probably make everything consistent with single quotes. |
I don't believe that it was your IDE - pretty sure it was the prettier workflow - see this commit: 5b4b5ba Assuming you're using VS code - any auto-formatting should be following the guidelines in the prettier settings. The real question is why wasn't this code already auto-formatted? |
@danieltott it's definitely my bad. I merged in that PR to move everything to docusaurus, and I didn't realize that. |
Or it was ghosts... 👻 |
Okay, that is really weird though. If you look at Ayu's PR, you'll see that there was a prettier workflow commit on hers as well! Then Bekah made a commit, prettier ran again, and she merged it. It doesn't make sense why that first prettier commit wasn't there anymore. |
7378794
to
3296ea9
Compare
OK - I fixed up the branch to only contain changes to that one file. I didn't asses the content changes though so won't approve just based on that |
Thank youuuuu! 😍 Can you revert that markdown change though? It's an email autolink. Don't TEST me on my markdown! |
It was breaking the docusaurus build ¯_(ツ)_/¯ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @meg-gutshall,
There are a couple things that need to be fixed here before merging in.
Other than these, it's good to go! 🚀
I'm approving to save time. 👍🏼
docs/coffees/mcs/README.md
Outdated
> [!NOTE] | ||
> While the welcome is happening, the Zoom host of the day creates the breakout rooms. Signal to the host to open the rooms once you've finished reading the welcome announcements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: This syntax is to add admonition in GitHub. But Docusaurus has different syntax.
> [!NOTE] | |
> While the welcome is happening, the Zoom host of the day creates the breakout rooms. Signal to the host to open the rooms once you've finished reading the welcome announcements. | |
:::note | |
While the welcome is happening, the Zoom host of the day creates the breakout rooms. Signal to the host to open the rooms once you've finished reading the welcome announcements. | |
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the helpful documentation link! Now that I'm looking at it, this should probably be INFO instead of NOTE.
docs/coffees/mcs/README.md
Outdated
> [!NOTE] | ||
> Details for these announcements can be found on the [website's events calendar](https://virtualcoffee.io/events). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> [!NOTE] | |
> Details for these announcements can be found on the [website's events calendar](https://virtualcoffee.io/events). | |
:::note | |
Details for these announcements can be found on the [website's events calendar](https://virtualcoffee.io/events). | |
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this one TIP instead of NOTE.
Linked Issue
Closes #482
Description
I removed the store link from the block the MC pastes in the Zoom chat.
I also cleaned the script up a bit.
Code of Conduct