Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughTwo files were modified to extend proxy protocol support. A sample configuration file now includes a SOCKS5 with remote DNS proxy example, and the HTTP utility module was updated to recognise socks5h protocol URLs alongside existing socks5 handling, directing both to the same dispatcher mechanism. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
socks5h://addon proxy URLs through the SOCKS dispatcher pathsocks5://behavior unchangedsocks5h://usage in.env.sampleProblem
ADDON_PROXY=socks5h://...was not recognized as SOCKS ingetProxyAgent().It fell back to Undici
ProxyAgent, which only accepts HTTP(S) proxy URLs, causing runtime errors like:Invalid URL protocol: the URL must start with http: or https:.Fix
Treat both
socks5:andsocks5h:as SOCKS5 protocols and usesocksDispatcherfor both.Notes
builtin,stremthru,mediaflow)ADDON_PROXYSummary by CodeRabbit
Release Notes
New Features
Documentation