Skip to content

fix(cmd): make ConfigFlags persistent and propagate IOStreams #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VioletCranberry merged 1 commit into from
May 6, 2025
Merged

fix(cmd): make ConfigFlags persistent and propagate IOStreams #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,21 @@ func newCliOptions(streams genericclioptions.IOStreams) *cliOptions {
func NewRootCmd(streams genericclioptions.IOStreams) *cobra.Command {
var target string
var params []string
cliOptions := newCliOptions(streams)
cliOpts := newCliOptions(streams)

rootCmd := &cobra.Command{Use: "node-ssm", SilenceUsage: true}
rootCmd := &cobra.Command{
Use: "node-ssm",
SilenceUsage: true,
}

// Make all ConfigFlags (--kubeconfig, --context, etc.) persistent.
cliOpts.flags.AddFlags(rootCmd.PersistentFlags())

// Wire up the IOStreams on the root command.
rootCmd.SetIn(cliOpts.In)
rootCmd.SetOut(cliOpts.Out)
rootCmd.SetErr(cliOpts.ErrOut)

cliOptions.flags.AddFlags(rootCmd.Flags())
rootCmd.AddCommand(newStartSessionCmd(cliOptions, &target, &params))
rootCmd.AddCommand(newStartSessionCmd(cliOpts, &target, &params))
return rootCmd
}
8 changes: 7 additions & 1 deletion cmd/startSession.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,16 @@ func newStartSessionCmd(opts *cliOptions, target *string, params *[]string) *cob
return nil
},
}

// Explicitly re-use the same IOStreams on this sub-command.
startSessionCmd.SetIn(opts.In)
startSessionCmd.SetOut(opts.Out)
startSessionCmd.SetErr(opts.ErrOut)

// Define flags.
startSessionCmd.Flags().
StringVar(target, "target", "", "EKS node name (private-dns-name or instance Id)")
_ = startSessionCmd.MarkFlagRequired("target")

startSessionCmd.Flags().
StringSliceVar(params, "session-params", []string{}, "SSM session parameters")
return startSessionCmd
Expand Down