errors resolved

Vinyla · Mar 1, 2021 · fc011d1 · fc011d1
1 parent b5a5069
commit fc011d1
Show file tree

Hide file tree

Showing 3 changed files with 511 additions and 466 deletions.
diff --git a/app.js b/app.js
@@ -4,55 +4,54 @@ const navLogo = document.querySelector('#navbar__logo');
 
 //Display Mobile Menu
 const mobileMenu = () => {
-    menu.classList.toggle('is-active');
-    menuLinks.classList.toggle('active');
-}
+  menu.classList.toggle('is-active');
+  menuLinks.classList.toggle('active');
+};
 
 menu.addEventListener('click', mobileMenu);
 
 //Show active menu when scrolling
 
 const highlightMenu = () => {
-    const elem = document.querySelector('.highlight')
-    const homeMenu = document.querySelector('#home-page')
-    const aboutMenu = document.querySelector('#about-page')
-    const knowledgeMenu = document.querySelector('#knowledge-page')
-    let scrollPos = window.scrollY
-    // console.log(scrollPos);
-
-    //adds 'highlight' class to my menu items
-
-    if(window.innerWidth > 960 && scrollPos < 600) {
-        homeMenu.classList.add('highlight')
-        aboutMenu.classList.remove('highlight')
-        return
-    } else if (window.innerWidth > 960 && scrollPos < 1400) {
-        aboutMenu.classList.add('highlight')
-        homeMenu.classList.remove('highlight')
-        knowledgeMenu.classList.remove('highlight')
-        return
-    } else if (window.innerWidth > 960 && scrollPos < 2345) {
-        aboutMenu.classList.remove('highlight')
-        knowledgeMenu.classList.add('highlight')
-        return
-    }
-    if((elem && window.innerWidth < 960 && scrollPos < 600) || elem ) {
-        elem.classList.remove('highlight')
-    }
-}
- window.addEventListener('scroll', highlightMenu);
- window.addEventListener('click', highlightMenu);
+  const elem = document.querySelector('.highlight');
+  const homeMenu = document.querySelector('#home-page');
+  const aboutMenu = document.querySelector('#about-page');
+  const knowledgeMenu = document.querySelector('#knowledge-page');
+  let scrollPos = window.scrollY;
+  // console.log(scrollPos);
+
+  //adds 'highlight' class to my menu items
+
+  if (window.innerWidth > 960 && scrollPos < 600) {
+    homeMenu.classList.add('highlight');
+    aboutMenu.classList.remove('highlight');
+    return;
+  } else if (window.innerWidth > 960 && scrollPos < 1400) {
+    aboutMenu.classList.add('highlight');
+    homeMenu.classList.remove('highlight');
+    knowledgeMenu.classList.remove('highlight');
+    return;
+  } else if (window.innerWidth > 960 && scrollPos < 2345) {
+    aboutMenu.classList.remove('highlight');
+    knowledgeMenu.classList.add('highlight');
+    return;
+  }
+  if ((elem && window.innerWidth < 960 && scrollPos < 600) || elem) {
+    elem.classList.remove('highlight');
+  }
+};
+window.addEventListener('scroll', highlightMenu);
+window.addEventListener('click', highlightMenu);
 
 //Close mobile menu on click
 
 const hideMobileMenu = () => {
-    const menuBars = document.querySelector('.is-active')
-    if(window.innerWidth <= 768 && menuBars) {
-        menu.classList.toggle('is-active')
-        menuLinks.classList.remove('active')
-    }
-}
+  const menuBars = document.querySelector('.is-active');
+  if (window.innerWidth <= 768 && menuBars) {
+    menu.classList.toggle('is-active');
+    menuLinks.classList.remove('active');
+  }
+};
 
 menuLinks.addEventListener('click', hideMobileMenu);
 navLogo.addEventListener('click', hideMobileMenu);
-
diff --git a/index.html b/index.html
@@ -102,7 +102,7 @@ <h2>React</h2>
                     <a href="https://www.facebook.com/IrMMMa/" class="social__link" target="_blank"><i class="fab fa-facebook"></i></a>
                     <a href="/" class="social__link" target="_blank"><i class="fab fa-instagram"></i></a>
                     <a href="/" class="social__link" target="_blank"><i class="fab fa-linkedin"></i></a>
-                    <a href="/" class="https://github.com/Vinyla" target="_blank"><i class="fab fa-github"></i></i></a>
+                    <a href="https://github.com/Vinyla" class="social__link" target="_blank"><i class="fab fa-github"></i></i></a>
                 </div>
             </div>
         </section>