Codemod v3 slots improvements #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillplatonov
changed the title
kirillplatonov
changed the title
Spone
reviewed
May 8, 2023
Spone
reviewed
May 10, 2023
Spone
reviewed
May 10, 2023
Spone
reviewed
May 10, 2023
Spone
reviewed
May 10, 2023
|
@Spone can we merge it at the current state? I included this class in Polaris ViewComponents v1 release and tested upgrade on a couple production apps. It works great. Even if the current implementation is not perfect it will be beneficial to have it shipped with ViewComponent now when people are doing upgrades to v3. In a couple of months this will be less useful I suppose. |
|
I agree. What do you think @joelhawksley? |
Gemfile
Outdated
| @@ -14,7 +14,7 @@ group :test do | |||
| gem "cuprite", "~> 0.8" | |||
| gem "puma", "~> 5" | |||
|
|
|||
| gem "selenium-webdriver", "~> 4" | |||
| gem "selenium-webdriver", "~> 4", "< 4.9.1" | |||
There was a problem hiding this comment.
Do you still need this? I'm wary of introducing such a restriction as it is something we'll have to eventually remove.
kirillplatonov
requested review from
boardfish,
juanmanuelramallo and
BlakeWilliams
as code owners
Co-authored-by: Hans Lemuet <[email protected]>
Co-authored-by: Hans Lemuet <[email protected]>
|
@joelhawksley please note that this PR is a contribution to #1669. We'll need to make a final review there once merged. |
Spone
approved these changes
Jun 29, 2023
|
Let's wrap this up in #1669! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes improvements for #1669:
bin/rails view_component:detect_legacy_slotsbin/rails view_component:migrate_legacy_slots