add support for configuring log level using custom rules #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryk-dk
reviewed
May 22, 2025
There was a problem hiding this comment.
@Loori-R , could you please fix backend part, because of linter
Loori-R
force-pushed
the
issue-294/congifure-log-level
branch
2 times, most recently
from
0cc4dfe to
d28a5bf
Compare
Loori-R
force-pushed
the
issue-294/congifure-log-level
branch
from
d28a5bf to
8f11151
Compare
Fixed |
dmitryk-dk
reviewed
May 23, 2025
| return { | ||
| ...query, | ||
| step: `${step}s`, | ||
| field: HITS_BY_FIELD, | ||
| field: uniqFields, |
There was a problem hiding this comment.
I think we should rename JSON param to fields because it is an array now
| @@ -53,7 +53,7 @@ type Query struct { | |||
| IntervalMs int64 `json:"intervalMs"` | |||
| MaxLines int `json:"maxLines"` | |||
| Step string `json:"step"` | |||
| Field string `json:"field"` | |||
There was a problem hiding this comment.
it is better to name the JSON field as fields because it is a slice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds a "Log level rules" section to the datasource configuration screen. It allows users to define custom rules for dynamically assigning log levels based on field values.
Related issue: #294, #209, #201
How it works
Click "Add rule" to create a new rule. Each rule consists of the following elements:
Equals,Not equal,Matches regex,Less than,Greater than.critical,warning,error,info,debug,trace,unknown.After adding or editing rules, make sure to click "Save & test" to apply the updated configuration.
Rule priority
If multiple rules match, the first one in the list takes precedence.