Skip to content

feat: Veto Power for Beneficiaries on Admin Changes (Defensive Governance)#172

Merged
JerryIdoko merged 2 commits intoVesting-Vault:mainfrom
BarryArinze:feat/beneficiary-veto-power
Mar 24, 2026
Merged

feat: Veto Power for Beneficiaries on Admin Changes (Defensive Governance)#172
JerryIdoko merged 2 commits intoVesting-Vault:mainfrom
BarryArinze:feat/beneficiary-veto-power

Conversation

@BarryArinze
Copy link
Copy Markdown
Contributor

🧩 Overview

This PR introduces a "Defensive Governance" mechanism that empowers beneficiaries to veto critical admin actions such as contract upgrades and admin rotation.

A 72-hour challenge window is enforced for all sensitive operations. During this period, beneficiaries can collectively reject the action if more than 51% of the locked token value votes against it.

⚙️ Key Features

  • 72-hour challenge period for:
    • Contract upgrades
    • Admin rotation
  • Token-weighted voting by beneficiaries
  • Automatic cancellation if >51% votes "No"
  • Transparent on-chain governance process
  • Protection against malicious or unilateral admin actions

🏗️ Implementation Details

  • Introduced "pending admin action" state with timestamp
  • Added voting mechanism weighted by locked token balances
  • Implemented challenge window validation (72 hours)
  • Added execution guard:
    • Action executes only if NOT vetoed after window
  • Auto-cancel logic when veto threshold is exceeded
  • Emitted events for:
    • Action proposed
    • Votes cast
    • Action executed or vetoed

🔐 Security Impact

  • Prevents unauthorized or malicious upgrades
  • Removes single point of failure (admin authority)
  • Aligns protocol governance with decentralized principles
  • Provides investor-grade protection for locked assets

🧪 Testing

  • Unit tests for:
    • Proposal creation
    • Voting (weighted logic)
    • Veto threshold enforcement (>51%)
    • Challenge window expiration
  • Edge cases:
    • Exactly 51% vs >51%
    • Late votes after deadline
    • Multiple concurrent proposals

🚀 Impact

  • Shifts governance from centralized control to collaborative consensus
  • Increases trust among beneficiaries and investors
  • Strengthens protocol resilience and transparency

🔗 Related Issues

Closes #107
Closes #54

🏷️ Labels

security, governance, logic

@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 24, 2026

@BarryArinze Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@JerryIdoko JerryIdoko merged commit bf426d4 into Vesting-Vault:main Mar 24, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#54. Create Veto_Power_for_Beneficiaries_on_Admin_Changes

2 participants