Skip to content

Landing page#26

Open
misudesu wants to merge 12 commits intoVerseWise:release/1.0from
misudesu:landingPage
Open

Landing page#26
misudesu wants to merge 12 commits intoVerseWise:release/1.0from
misudesu:landingPage

Conversation

@misudesu
Copy link
Copy Markdown

@misudesu misudesu commented Nov 9, 2024

No description provided.

@Efode-r2d2
Copy link
Copy Markdown
Contributor

Efode-r2d2 commented Nov 9, 2024

Would be nice if you could attach a screenshot as well.

  • attach screenshot

src/ChatApp.jsx Outdated
</div>

</div>
<p className="mb-5 text-center text-gray-400 mt-2 text-sm">VERSEwise Ai can make mistakes. Check important info.</p>
Copy link
Copy Markdown
Contributor

@Efode-r2d2 Efode-r2d2 Nov 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract text to a resource file, as we might include localization in the future, and it is also good for reusability(incase).

  • Extract string values to a resource

Welcome to our Chat Bot!
<div className={` flex flex-col text-center l:text-start max-w-[70%] mx-auto mt-[20px] lg:w-[700px] lg:mr-10 gap-[20px] justify-start`}>
<div className={`mx-auto text-[32px] leading-[44px] font-semibold w-[90%] l:w-full l:font-normal l:text-[64px] l:leading-[87px] mt-26 lg:mt-80`}>
Introducing VERSEwise
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Extract string values to a resource file

<div className='font-semibold text-[14px] leading-[19px] text-[#FFFFFF78] l:text-[24px] l:leading-[32px] l:font-normal'>
The fear of the LORD is the beginning of wisdom, and knowledge of
the Holy One is understanding.
Explore Personalized Spiritual Guidance with Versewise – Your AI-Powered Companion for Wisdom, Insight, and Clarity.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Extract string values to a resource file

@Efode-r2d2
Copy link
Copy Markdown
Contributor

Efode-r2d2 commented Nov 9, 2024

Would really be nice if you follow commit message formats

  • refer to our commit message formats (either from cms or versewise commit history)

};

// Helper functions to abstract the logic of getting path data, stroke color, and blur paths.
function getPathD(index) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I highly recommend extracting helper functions into separate files

  • Extract helpers into files

@EyosiSol
Copy link
Copy Markdown

maybe if the "patterned background" is extended to the "your spritual questions" part too. and the CTA button have a the "#EF4225" background color with white

@misudesu
Copy link
Copy Markdown
Author

test
i need some to update the image with nice one.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing unused commented code

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest moving inline styles to a separate CSS or SCSS file.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@misudesu we can't merge this with fake testimonials. Lets discuss this in discord and come up with a solution

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaya, that is right , i put how it look , when we write our testimonial or collate sample from neighbor it will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants