fix(network): replace LOCAL_HOSTS set with isLoopback predicate - #85
Merged
N-i-xx merged 2 commits intoAug 27, 2026
Merged
Conversation
The bare '::1' entry in LOCAL_HOSTS was dead code — the WHATWG URL parser always returns IPv6 hostnames in bracketed form ([::1]), so it could never match parsed.hostname. The exact-match set also only covered 127.0.0.1, leaving the rest of the 127.0.0.0/8 loopback range (e.g. 127.0.0.2) unrecognised and treated as remote, making allowInsecureLocalhost behave inconsistently. Replace the set with an isLoopback() predicate that covers: - 'localhost' - '[::1]' (the form the URL parser actually returns) - the full 127.0.0.0/8 range via regex Add tests for http://127.0.0.2:8000 and http://[::1]:8000 with and without allowInsecureLocalhost. Closes Vero-protocol#75
N-i-xx
approved these changes
Aug 27, 2026
8 tasks
|
Merged — thanks for the contribution! If you've got a moment, a rating on GrantFox helps the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes dead code and inconsistent loopback detection in
validateUrl.Problem
LOCAL_HOSTScontained a bare'::1'entry that could never match — the WHATWG URL parser always returns IPv6 hostnames in bracketed form (new URL('http://[::1]:8000').hostname === '[::1]'), so the bare form is unreachable.The set also only covered
127.0.0.1exactly, leaving the rest of the127.0.0.0/8loopback range (e.g.127.0.0.2) unrecognised and treated as remote.allowInsecureLocalhosttherefore behaved inconsistently for addresses a developer would reasonably expect to be local.Changes
src/network/index.ts: removedLOCAL_HOSTSset; replaced with anisLoopback(hostname)predicate covering'localhost','[::1]'(the bracketed form the URL parser actually produces), and the full127.0.0.0/8range via regex.src/__tests__/network.test.ts: added tests forhttp://127.0.0.2:8000andhttp://[::1]:8000both with and withoutallowInsecureLocalhost.Tested
All 193 tests pass (
npx jest), including 2 new cases covering the previously untested addresses.Closes #75