fix: route proxy upgrade through governance-gated flow to prevent single-key bypass - #226
Open
ugoocreates-pixel wants to merge 1 commit into
Open
Conversation
Contributor
|
please ensure all checks pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #200
Fixes a critical vulnerability where
UpgradeableProxy::upgradebypasses the multi-sig and timelock governance by allowing a single admin to immediately replace the contract's code.Changes:
UpgradeableProxy::upgradewith a call tocrate::upgrade::upgrade.proposal_idto be passed, ensuring the upgrade is properly gated by the multi-sig approval and timelock mechanisms.NotInitializedandInvalidWasmHashvariants fromProxyError.