Skip to content

fix: use constant-time comparison for relayer API keys #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
N-thnI merged 1 commit into from
Aug 24, 2026
Merged

fix: use constant-time comparison for relayer API keys #224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions engine-bridge/src/relayer-auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { timingSafeEqual } from "crypto";
import type { IncomingMessage } from "http";

export interface RelayerAuthOptions {
Expand Down Expand Up @@ -37,15 +38,19 @@ function extractApiKey(req: IncomingMessage): string | null {
}

export class RelayerAuth {
private readonly apiKeys: Set<string>;
private readonly apiKeys: string[];

constructor(options: RelayerAuthOptions = {}) {
this.apiKeys = new Set(options.apiKeys ?? []);
this.apiKeys = options.apiKeys ?? [];
}

verifyClient(info: VerifyClientInfo, cb: VerifyClientCallback): void {
const key = extractApiKey(info.req);
if (key && this.apiKeys.has(key)) {
if (key && this.apiKeys.some(apiKey => {
const candidate = Buffer.from(key);
const expected = Buffer.from(apiKey);
return candidate.length === expected.length && timingSafeEqual(candidate, expected);
})) {
cb(true);
return;
}
Expand Down
Loading