Fix AuditGuardContract security-theater vulnerability - #219
Merged
Conversation
N-thnI
approved these changes
Aug 21, 2026
5 tasks
Contributor
|
Merged — thanks for the contribution! |
Contributor
|
Also — if you've got a moment, a rating on GrantFox helps the project. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #188
Fixes the security-theater vulnerability in
AuditGuardContractby implementing genuine verification logic.Changes made:
verify_contextnow reads the author's verification status from actual contract state (env.storage().instance().get(&author)) rather than trusting a caller-supplied boolean. Aset_verifiedfunction was added to mutate this state.validate_and_auditnow usesenv.crypto().ed25519_verify()to actually verify the provided signature against the payload. The function signature was updated to accept apublic_key: BytesN<32>to enable proper cryptographic validation.src/audit-guard/src/lib.rsproving that:AuditGuardError::InvalidPayload.