Refactor process_vote to reuse vote_inner shared vote-processing logic - #296
Open
Scepter00 wants to merge 3 commits into
Open
Refactor process_vote to reuse vote_inner shared vote-processing logic#296Scepter00 wants to merge 3 commits into
Scepter00 wants to merge 3 commits into
Conversation
Contributor
|
The only failing step is Format check — Run |
Contributor
|
please ensure all checks pass |
Contributor
|
please ensure all checks pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #198
process_vote no longer duplicates the per-task vote-processing sequence (duplicate-vote check, task fetch, cancellation check, consensus application, resolution + vault release, persistence, event emission). It now performs only the guardian-level checks (pause, auth, reentrancy lock, guardian status, balance/threshold, reputation) and delegates the rest to vote_inner, which process_vote_batch already used. vote_inner and process_vote_batch are unchanged.
Note: I couldn't run the local test suite due to a Windows/mingw toolchain issue (dlltool.exe not found) unrelated to this change — cargo build compiles cleanly. Deferring to CI to confirm the full test suite passes.