Skip to content

Add rustdoc comments to src/contracts/logic.rs and proxy_entry.rs - #293

Open
EmmanuelAdah wants to merge 12 commits into
Vero-protocol:mainfrom
EmmanuelAdah:emmanuel-adah
Open

Add rustdoc comments to src/contracts/logic.rs and proxy_entry.rs#293
EmmanuelAdah wants to merge 12 commits into
Vero-protocol:mainfrom
EmmanuelAdah:emmanuel-adah

Conversation

@EmmanuelAdah

@EmmanuelAdah EmmanuelAdah commented Aug 21, 2026

Copy link
Copy Markdown

Closes #246

📝 Summary

This PR improves the developer experience and crate documentation by adding detailed, structured rustdoc comments to all public-facing and crate-internal functions within the core contract modules (logic.rs and proxy_entry.rs).

🛠 What was done

Added /// doc comments to all pub and pub(crate) functions in:

src/contracts/logic.rs
src/contracts/proxy_entry.rs

Standardized the documentation format for each function to explicitly include:

Parameters: Descriptions of all input arguments.
Returns: Expected successful return types/values.
Errors: Specific conditions that will trigger a ContractError or panic.
Side Effects: Explicit mentions of storage reads/writes, emitted events, required authorizations, and external cross-contract calls.

⚠️ Impact & Functional Changes

Zero functional changes. This PR is strictly limited to documentation.

cargo doc will now generate clean, warning-free, and highly readable HTML documentation for the contract's API and internal logic.

Note: The #![allow(missing_docs)] attribute in proxy_entry.rs can now be safely removed in a future strict-linting pass if desired, as all functions are fully documented.

✅ Checklist

  • Code compiles cleanly (cargo build)
  • Documentation builds perfectly (cargo doc --no-deps --document-private-items)
  • No functional logic was altered

@EmmanuelAdah EmmanuelAdah changed the title Add rustdoc comments to src/contracts/logic.rs and proxy_entry.rs #246 Add rustdoc comments to src/contracts/logic.rs and proxy_entry.rs Aug 21, 2026
@N-thnI

N-thnI commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Please resolve conflicts

@N-thnI

N-thnI commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

please ensure all checks pass

@N-thnI

N-thnI commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

This has gone into conflict with main — could you rebase onto main and resolve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add rustdoc comments to src/contracts/logic.rs and proxy_entry.rs

2 participants