Add rustdoc comments to src/contracts/logic.rs and proxy_entry.rs - #293
Open
EmmanuelAdah wants to merge 12 commits into
Open
Add rustdoc comments to src/contracts/logic.rs and proxy_entry.rs#293EmmanuelAdah wants to merge 12 commits into
EmmanuelAdah wants to merge 12 commits into
Conversation
Contributor
|
Please resolve conflicts |
Contributor
|
please ensure all checks pass |
Contributor
|
This has gone into conflict with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #246
📝 Summary
This PR improves the developer experience and crate documentation by adding detailed, structured rustdoc comments to all public-facing and crate-internal functions within the core contract modules (logic.rs and proxy_entry.rs).
🛠 What was done
Added /// doc comments to all pub and pub(crate) functions in:
src/contracts/logic.rs
src/contracts/proxy_entry.rs
Standardized the documentation format for each function to explicitly include:
Parameters: Descriptions of all input arguments.
Returns: Expected successful return types/values.
Errors: Specific conditions that will trigger a ContractError or panic.
Side Effects: Explicit mentions of storage reads/writes, emitted events, required authorizations, and external cross-contract calls.
Zero functional changes. This PR is strictly limited to documentation.
cargo doc will now generate clean, warning-free, and highly readable HTML documentation for the contract's API and internal logic.
Note: The #![allow(missing_docs)] attribute in proxy_entry.rs can now be safely removed in a future strict-linting pass if desired, as all functions are fully documented.
✅ Checklist