Repository navigation
chore(deps): pin PolyFun's inductive return predicate and retire the support workaround - #1204
Conversation
…or support PolyFun's `MonadAttach` instance for `FreeM P` now uses an inductive `FreeM.CanReturn`. With it, neither the kernel nor the elaborator evaluates a computation to compare `x ∈ support mx` with `x ∈ support my`. The proof of Verified-zkEVM#1197 checks without the workaround from gotcha 13b, including `simp` with `mem_support_bind_iff` on a `do` block, passing `h : x ∈ support mx` to a lemma, an `abbrev` and `unfold`. `VCVioTest/OracleComp/SupportKernel.lean` checks those four cases. `support (pure x) = {x}` no longer holds by `rfl` on `OracleComp`. Proofs that used a membership in the support of `pure` as an equation now go through `eq_of_mem_support_pure` or `mem_support_pure_iff`. Gotcha 13b describes the inductive predicate and keeps the general warning about sets computed by recursion over a program (leanprover/lean4#16613). The PolyFun pin is a cherry-pick of the PolyFun change onto the previous pin, for integration testing. It must be replaced by the merged PolyFun commit before this lands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pins PolyFun at f3eb8333 in the root lakefile and both manifests. The PolyFun changes since 528b3b1 need the compatibility edits from Verified-zkEVM#1186 in the lower-expectation and relational-algebra files and their tests. They are copied unchanged, so Verified-zkEVM#1186 rebases onto this with only its own content left. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🤖 PR Summary
PolyFun pin to inductive return predicate & removal of support workaround\n\nInfrastructure / CI\n- The PolyFun dependency is pinned at Statistics
Lean Declarations ✏️ Added: 7 declaration(s)
✏️ Affected: 4 declaration(s) (line number changed)
📄 **Per-File Summaries**
Last updated: 2026-11-21 04:55 UTC. |
Verified-zkEVM/PolyFun#509 merged as 713d8857, whose tree is identical to the PR head f3eb8333 that this branch was validated against. The root lakefile and both manifests now name the merged commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main now pins PolyFun at 713d8857 (Verified-zkEVM#1204), a descendant of this branch's pin 77731620, and carries this branch's compatibility edits, so the pin conflicts resolve to main's files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main now pins PolyFun at 713d8857 (Verified-zkEVM#1204), a descendant of this branch's pin bdc1cde7, so the pin conflicts resolve to main's files. The upstream-alignment ledger keeps both new rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pins PolyFun at
713d8857, the merge of Verified-zkEVM/PolyFun#509, in the root lakefile and both manifests. That commit makes the return predicate ofFreeM, and so ofOracleComp, the inductivePFunctor.FreeM.CanReturn. Neither the kernel nor the elaborator reduces it, so comparingx ∈ support mxwithx ∈ support mycomparesmxwithmyand runs neither computation.The reproduction from #1197 now checks without the workaround from gotcha 13b.
VCVioTest/OracleComp/SupportKernel.leankeeps four cases: the originalsimpproof withmem_support_bind_iffon adoblock,h : r ∈ support sampleThenFivepassed to a lemma, anabbrevof the computation, andunfold. Onmainall four fail, in the kernel or at the elaborator's recursion limit. Gotcha 13b now describes the inductive predicate and keeps the warning for other sets defined by recursion over a program (leanprover/lean4#16613), anddocs/reading/upstream-alignment.mdrecords the change.support (pure x) = {x}no longer holds byrflonOracleComp. About 40 proofs in 21 files used a membership in the support ofpureas an equation, throughsubst, anrflpattern,congrArg,▸orProd.ext_iff. They now useeq_of_mem_support_pureormem_support_pure_iff. Two call sites move to PolyFun's renamedHandler.support_run_liftM_id_withChargeWandIsChargeBound.bind_support.The pin also covers the PolyFun changes since
528b3b1. The compatibility edits for them, in the lower-expectation and relational-algebra files and their tests, are the same as in #1186, which can rebase onto this.Verification
On
77ead20ef,./scripts/validate.sh --lint --test --axiomspassed, including the init-sweep ratchet,lake testand the axiom sweep, with zero sorry or nonstandard-axiom taint across 32,432 declarations in 1,335 modules. That run resolved PolyFun from a local copy off3eb8333, the head of PolyFun#509, with the optional native FFI backends disabled. The PR's CI, which resolves PolyFun from a fresh checkout, passed oneeb2c5d70, which adds only the ledger row. PolyFun#509 merged as713d8857, whose tree is identical tof3eb8333, and775892ae7moves the pin to it. With PolyFun checked out at713d8857,lake build --no-buildreports every library and test target up to date.VCVioTest/OracleComp/SupportKernel.leanfails onmainat all four cases.