[VEN-3277][VEN-3328]: Missing track of tokens converted in a private conversion #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chechu
reviewed
Jul 9, 2025
| address, | ||
| uint256 | ||
| ) internal override { | ||
| emit AssetTransferredToDestination(destinationAddress, comptroller, tokenAddressIn, convertedTokenInBalance); |
Contributor
There was a problem hiding this comment.
We could emit the event only if (convertedTokenInBalance > 0), as we do in the RiskFundConverter
chechu
previously approved these changes
Jul 10, 2025
Debugger022
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AssetTransferredToDestinationwhenever aprivateConversionis initiated by aSingleTokenConverterSingleTokenConverterimplementation on BNB , Ethereum and Arbitrum .