Skip to content

Make $handleName nullable in afterAddHandle plugin #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

peterjaap
Copy link

We are running into this error, which is fixed by adding null to the type hint.

TypeError: Vendic\OptimizeCacheSize\Plugin\RemoveHandlersPlugin::afterAddHandle(): Argument #3 ($handleName) must be of type array|string, null given, called in /data/web/releases/20250401082050/vendor/magento/framework/Interception/Interceptor.php on line 146 and defined in /data/web/releases/20250401082050/vendor/vendic/module-optimize-cache-size/Plugin/RemoveHandlersPlugin.php:24
Stack trace:
#0 /data/web/releases/20250401082050/vendor/magento/framework/Interception/Interceptor.php(146): Vendic\OptimizeCacheSize\Plugin\RemoveHandlersPlugin->afterAddHandle()
#1 /data/web/releases/20250401082050/vendor/magento/framework/Interception/Interceptor.php(153): Hyva\Theme\Framework\View\Model\Layout\Merge\Interceptor->Magento\Framework\Interception\{closure}()
#2 /data/web/releases/20250401082050/generated/code/Hyva/Theme/Framework/View/Model/Layout/Merge/Interceptor.php(23): Hyva\Theme\Framework\View\Model\Layout\Merge\Interceptor->___callPlugins()
#3 /data/web/releases/20250401082050/vendor/magento/framework/Pricing/Render/Layout.php(45): Hyva\Theme\Framework\View\Model\Layout\Merge\Interceptor->addHandle()
#4 /data/web/releases/20250401082050/vendor/magento/framework/Pricing/Render.php(69): Magento\Framework\Pricing\Render\Layout->addHandle()
#5 /data/web/releases/20250401082050/vendor/magento/framework/View/Element/AbstractBlock.php(288): Magento\Framework\Pricing\Render->_prepareLayout()
#6 /data/web/releases/20250401082050/vendor/magento/framework/View/Layout/Generator/Block.php(149): Magento\Framework\View\Element\AbstractBlock->setLayout()
#7 /data/web/releases/20250401082050/vendor/magento/framework/View/Layout/GeneratorPool.php(93): Magento\Framework\View\Layout\Generator\Block->process()
#8 /data/web/releases/20250401082050/vendor/magento/framework/View/Layout.php(365): Magento\Framework\View\Layout\GeneratorPool->process()
#9 /data/web/releases/20250401082050/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\View\Layout->generateElements()
#10 /data/web/releases/20250401082050/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\View\Layout\Interceptor->___callParent()
#11 /data/web/releases/20250401082050/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\View\Layout\Interceptor->Magento\Framework\Interception\{closure}()
#12 /data/web/releases/20250401082050/generated/code/Magento/Framework/View/Layout/Interceptor.php(32): Magento\Framework\View\Layout\Interceptor->___callPlugins()
#13 /data/web/releases/20250401082050/vendor/magento/framework/View/Layout/Builder.php(129): Magento\Framework\View\Layout\Interceptor->generateElements()
#14 /data/web/releases/20250401082050/vendor/magento/framework/View/Page/Builder.php(65): Magento\Framework\View\Layout\Builder->generateLayoutBlocks()
#15 /data/web/releases/20250401082050/vendor/magento/framework/View/Layout/Builder.php(65): Magento\Framework\View\Page\Builder->generateLayoutBlocks()
#16 /data/web/releases/20250401082050/vendor/magento/framework/View/Page/Config.php(227): Magento\Framework\View\Layout\Builder->build()
#17 /data/web/releases/20250401082050/vendor/magento/framework/View/Page/Config.php(591): Magento\Framework\View\Page\Config->build()
#18 /data/web/releases/20250401082050/vendor/magento/framework/View/Page/Config.php(549): Magento\Framework\View\Page\Config->getElementAttribute()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant