Implement core logic for transliteration, sandhi, morphology, and analysis#2
Conversation
…lysis Co-authored-by: VedantMadane <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Fix python docs build: install 'llm' and 'dev' extras (litellm, numpy, pdoc3). - Fix python lint: use `uv sync --all-extras` to ensure dev deps (ruff) are installed. - Fix rust build-check on macOS: use `maturin build` instead of `cargo build` for proper extension module linking. - Fix security audit: upgrade `pyo3` to 0.24.1 (RUSTSEC-2025-0020). - Fix rust lint: run `cargo fmt`. - Fix clippy warnings: deprecation in `vedyut-core` and unused var in `vedyut-sanskritify`. Co-authored-by: VedantMadane <[email protected]>
- Add `pdoc3` to dev dependencies in `pyproject.toml` to fix `fastapi` module not found error in docs workflow. - Update `.github/workflows/docs.yml` to rely on `uv sync --all-extras` for dependency installation. - Implement `std::str::FromStr` for `Scheme` in `rust/vedyut-lipi/src/schemes.rs` to fix clippy `should_implement_trait` error. - Run `uv run ruff format .` to fix Python linting failures. - Fix logic error in `from_str` implementation to correctly call the trait method. Co-authored-by: VedantMadane <[email protected]>
1 participant
Replaced placeholders with working implementations in vedyut-lipi (transliteration), vedyut-sandhi (vowel sandhi), vedyut-prakriya (word generation for Bhvadi Lat), and vedyut-cheda (analyzer using lexicon). Also updated vedyut-core PyO3 bindings to support modern PyO3 0.21+ and fixed existing issues in vedyut-sanskritify.
Key changes:
PR created automatically by Jules for task 9442183823198293679 started by @VedantMadane