Core Prakriya Engine and Pilot Derivation Rules#1
Open
google-labs-jules[bot] wants to merge 6 commits intomainfrom
Open
Core Prakriya Engine and Pilot Derivation Rules#1google-labs-jules[bot] wants to merge 6 commits intomainfrom
google-labs-jules[bot] wants to merge 6 commits intomainfrom
Conversation
- Implemented `Prakriya`, `Term`, and `Tag` structures in `vedyut-prakriya`. - Implemented basic Ac-Sandhi rules in `vedyut-sandhi`. - Implemented Subanta derivation for `Rāma` śabda (derive_subanta). - Implemented Tinanta derivation for `Bhavati` (derive_tinanta). - Added unit tests for all implemented features.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Updated `Cargo.toml` in all crates to use versioned dependencies. - Updated `vedyut-core` to use PyO3 v0.22 `Bound` API. - Fixed lifetime issue in `vedyut-sanskritify`. - Verified build with `cargo build --release` and `maturin build --release`.
…erage - Defined `Rule` and `RuleRegistry` structs in `vedyut-prakriya` for scalable rule management. - Added `Step` tracking to `Prakriya` for derivation history. - Implemented core Samjna/Paribhasha rules (e.g., *Vrddhi*, *Guna*, *It-Samjna*). - Implemented comprehensive Ac-Sandhi rules (*Dirgha*, *Guna*, *Yan*, *Ayavayava*) and Visarga Sandhi. - Refactored `derive_subanta` and `derive_tinanta` to use the new rule engine. - Added support for i/u-stem declensions (e.g., *Hari* -> *Haraye*) via `gherṅiti` logic. - Verified all derivations with unit tests.
- Implemented rules 1.1.3 - 1.1.9 (Guna/Vrddhi constraints, Samyoga, Anunasika, Savarna). - Implemented 1.1.27 (Sarvanama) and 1.1.37 (Avyaya). - Implemented 1.1.52 (Alohntyasya). - Added `Tag` variants for new terms (Anunasika, Sarvanama, Avyaya). - Added unit tests for Anunasika, Sarvanama, and Avyaya definition.
- Implemented `Ad gunah` (6.1.87) and `Vrddhir eci` (6.1.88) with conflict resolution (Vrddhi blocks Guna). - Implemented `Jasah si` (7.1.17) for Sarvanama (Pronoun) declension (*Sarve*). - Implemented `Enhrasvat sambuddheh` (6.1.69) for Sambuddhi (Vocative) deletion (*He Rama*). - Implemented `Tita atmanepadanam tere` (3.4.79) for Atmanepada verbs (*Edhate*). - Added comprehensive tests for each case.
- Implemented feminine derivation with *Ajaadyatas tap* (4.1.4) and *Halnyabbhyo...* (6.1.68). - Implemented consonant sandhi rules: *Stoh scuna scuh* (8.4.40) and *Jhalam jaso ante* (8.2.39). - Implemented *Lit* Lakara (Perfect) support, including Dvitva (reduplication) and Abhyasa reduction. - Implemented special rules for Bhu in Lit (*Bhuvo vuk*). - Added comprehensive tests for all new features (*Aja*, *Vagisa*, *Ramashcit*, *Babhuva*).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the core derivation engine for Vedyut, following the Paninian grammar rules.
This includes:
Prakriyastate machine,Termwith tags.This serves as the foundation for implementing the remaining 4000 sutras.
PR created automatically by Jules for task 12508652883690944720 started by @VedantMadane