Cat Rain use Web Animation API instead of rAF loop#14
Open
Martin-Pitt wants to merge 2 commits intoVedalAI:mainfrom
Open
Cat Rain use Web Animation API instead of rAF loop#14Martin-Pitt wants to merge 2 commits intoVedalAI:mainfrom
Martin-Pitt wants to merge 2 commits intoVedalAI:mainfrom
Conversation
Use the Web Animation API for cat rain instead rAF loops run at 120Hz on, well, 120Hz displays, so the cats end up falling and spinning twice as fast. Now imagine how that felt like on a 240Hz display.
Cat Rain w/ Web Animation API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the Web Animation API for cat rain instead. (
Element.animate)rAF loops run at 120Hz on, well, 120Hz displays, so the cats end up falling and spinning twice as fast.
Now imagine how that feels like on a 240Hz display.
You can fix that by using delta time in the rAF animation loops but there is the Web Animation API which also animates it off the main thread and other good stuff.