Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test enhancement #2

Merged
merged 1 commit into from
Apr 21, 2019
Merged

Test enhancement #2

merged 1 commit into from
Apr 21, 2019

Conversation

peter279k
Copy link
Contributor

Changed log

  • Organize Travis CI setting to avoid invalid token.
  • Organize the autoload and autoload-dev namespace in composer.json setting.
  • Remove strict attribute in phpunit.xml setting.
  • Using the class-based PHPUnit namespace to be compatible with latest PHPUnit version.
  • Using the assertSame to check the $pdo class is the same.
  • Using the assertContains to check whether specific key is existed in the result array.

@jdpanderson
Copy link
Member

Looks good. I just have the one question about removing sudo:false from .travis.yml.

@peter279k
Copy link
Contributor Author

@jdpanderson, any update here?

Thanks.

@jdpanderson
Copy link
Member

I had meant to merge the day you answered my question. Thanks for chasing me. 😁

@jdpanderson jdpanderson merged commit f106748 into Vectorface:master Apr 21, 2019
@peter279k peter279k deleted the test_enhancement branch June 12, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpanderson jdpanderson jdpanderson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter279k @jdpanderson