Trainer: Refactor make_dataset_from_df #55
+194
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault class method and update function signatures to use Transformations directly."
…for better type safety and clarity in clustering function signatures.
…afety and streamline model retrieval in fine-tuning and training functions.
…arameters dataclasses for improved structure and type safety in model configuration across fine-tuning and training functions."
…YCond enum in dataset, model, and training modules for improved type safety and clarity in handling y column conditions."
…eplace string literals for loss type specification in fine-tuning and training modules, enhancing type safety and clarity.
…ng literals for scheduler specification in fine-tuning and training modules, enhancing type safety and clarity.
…sSecondMomentResampler to accept num_timesteps directly, replacing the diffusion object dependency, and enhance the ScheduleSampler enum with a method for creating samplers."
…ical_forward_backward_log and _compute_top_k functions to utilize the new ReductionMethod enum for improved type safety and consistency.
…e to the gaussian diffusion file
…o marcelo/classes-and-enums-2
…o marcelo/classes-and-enums-2
emersodb
reviewed
Oct 3, 2025
…factor-make-dataset-from-df
…factor-make-dataset-from-df
…ing' into marcelo/refactoring-pair-clustering
…factor-make-dataset-from-df
…factor-make-dataset-from-df
…factor-make-dataset-from-df
Base automatically changed from
marcelo/refactor-process-pipeline-data
to
main
October 6, 2025 20:35
fatemetkl
reviewed
Oct 7, 2025
fatemetkl
reviewed
Oct 7, 2025
fatemetkl
reviewed
Oct 7, 2025
fatemetkl
approved these changes
Oct 7, 2025
emersodb
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Fix
Short Description
Clickup Ticket(s): https://app.clickup.com/t/868fuke6e
Refactoring
make_dataset_from_dfinto smaller functions so we can remove the ignore from Ruff.Tests Added
NA, the functionality is not supposed to change.