Skip to content
This repository was archived by the owner on Jun 25, 2025. It is now read-only.

Remove ARC-related Obj-C Code from decompilation#52

Closed
0cyn wants to merge 5 commits intomasterfrom
arc_cleanup
Closed

Remove ARC-related Obj-C Code from decompilation#52
0cyn wants to merge 5 commits intomasterfrom
arc_cleanup

Conversation

@0cyn
Copy link
Copy Markdown
Member

@0cyn 0cyn commented Jan 24, 2023

No description provided.

@0cyn 0cyn self-assigned this Jan 24, 2023
0cyn
0cyn commented Jan 24, 2023
View reviewed changes
Comment thread MessageHandler.cpp Outdated
Comment thread MessageHandler.cpp Outdated
Comment thread MessageHandler.cpp Outdated
Comment thread MessageHandler.cpp Outdated
@0cyn 0cyn marked this pull request as ready for review January 24, 2023 21:16
@0cyn 0cyn requested a review from jonpalmisc January 24, 2023 21:16
0cyn
0cyn commented Jan 24, 2023
View reviewed changes
Comment thread MessageHandler.cpp Outdated
0cyn
0cyn commented Jan 24, 2023
View reviewed changes
Comment thread MessageHandler.cpp
@jonpalmisc
Copy link
Copy Markdown

jonpalmisc commented Jan 25, 2023

Before I do a review, I do believe that this should be placed behind a setting so that it can be enabled/disabled as desired.

@plafosse plafosse self-assigned this Jan 25, 2023
@plafosse plafosse self-requested a review January 25, 2023 19:20
jonpalmisc
jonpalmisc suggested changes Apr 11, 2023
View reviewed changes
Copy link
Copy Markdown

@jonpalmisc jonpalmisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursory glance did not reveal any catastrophic mistakes, just minor fixes needed. Not on a computer where I can test this functionally at the moment, however.

Question: What happens when the setting is toggled after initial analysis? My intuition would tell me that functions that end up getting re-analyzed would have the ARC code removed, but old ones wouldn't? Not sure what the "correct" behavior here should be though.

Comment thread Plugin.cpp Outdated
Comment thread Plugin.cpp Outdated
@0cyn
Copy link
Copy Markdown
Member Author

0cyn commented Jul 18, 2023

This is functional but appears to be partially broken on newer arm64 format binaries which stub code out heavily.

Merge blocked pending addressing Vector35/binaryninja-api#5563

@0cyn 0cyn mentioned this pull request Jul 18, 2023
Closed
@0cyn 0cyn closed this Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@plafosse plafosse Awaiting requested review from plafosse

1 more reviewer

@jonpalmisc jonpalmisc jonpalmisc requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@plafosse plafosse

@0cyn 0cyn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0cyn @jonpalmisc @plafosse