Skip to content

[WARP] Fix container list not refreshing for dynamically added contai… #7596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[WARP] Fix container list not refreshing for dynamically added contai… #7596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions plugins/warp/ui/containers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ class WarpContainersPane : public QWidget
{
// Retrieve all available containers
const auto all = Warp::Container::All();
m_containers = all; // copy vector<Ref<Container>>
m_containers = all;

for (const auto& c : m_containers)
{
Expand All @@ -159,10 +159,6 @@ class WarpContainersPane : public QWidget
auto* widget = new WarpContainerWidget(c, m_stack);
m_stack->addWidget(widget);
}

// Visual style: behave like a vertical tab bar
// m_list->setFrameShape(QFrame::NoFrame);
// m_list->setSpacing(0);
}

static int itemHeightPx()
Expand Down
1 change: 1 addition & 0 deletions plugins/warp/ui/plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ void WarpSidebarWidget::Update()
{
m_currentFunctionWidget->UpdateMatches();
m_matchedWidget->Update();
m_containerWidget->refresh();
// TODO: Obviously this probably should not be called here.
setMatcherActionIcon(false);
}
Expand Down