Skip to content

[FIX] web: properly handle row number column in ListRenderer #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imanie383 wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[FIX] web: properly handle row number column in ListRenderer #635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion addons/web/static/src/views/list/column_width_hook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,13 @@ function computeOptimalDateWidths() {
*/
function computeWidths(table, state, allowedWidth, startingWidths) {
let _columnWidths;
const headers = [...table.querySelectorAll("thead th")];
const headers = [...table.querySelectorAll("thead th:not(.o_rowno)")];
const rowNum = table.classList.contains("o_rowno_in_tree")
const columns = state.columns;

if (rowNum && startingWidths)
startingWidths.shift();

// Starting point: compute widths
if (startingWidths) {
_columnWidths = startingWidths.slice();
Expand Down Expand Up @@ -207,6 +211,8 @@ function computeWidths(table, state, allowedWidth, startingWidths) {
// Expand/shrink columns for the table to fill 100% of available space
const totalWidth = _columnWidths.reduce((tot, width) => tot + width, 0);
let diff = totalWidth - allowedWidth;
if (rowNum)
diff += DEFAULT_MIN_WIDTH/2;
if (diff >= 1) {
// Case 1: table overflows its parent => shrink some columns
const shrinkableColumns = [];
Expand Down Expand Up @@ -278,6 +284,8 @@ function computeWidths(table, state, allowedWidth, startingWidths) {
}
}
}
if (rowNum)
_columnWidths.unshift(SELECTOR_WIDTH);
return _columnWidths;
}

Expand Down