[FIX] sms_marketing: ensure SMS links use the correct domain#622
Open
imanie383 wants to merge 1 commit intoVauxoo:16.0-ircfrom
Open
[FIX] sms_marketing: ensure SMS links use the correct domain#622imanie383 wants to merge 1 commit intoVauxoo:16.0-ircfrom
imanie383 wants to merge 1 commit intoVauxoo:16.0-ircfrom
Conversation
Before this commit, the generated SMS link did not include the SMS code because it was created using the domain of the second website instead of the intended one. This happened because the comparison was made against the `web.base.url` parameter instead of the current website domain. With this fix, the system correctly uses the current website domain for both link generation and comparison, ensuring the correct domain is applied. Steps to reproduce: - Go to **SMS Marketing**. - Create a new `mailing.mailing` with **Concat Recipients**. - Set up **two websites** with different domains. - Configure `web.base.url` using the same domain as the **first website**. - Log in to the **second website**. - Send the `mailing.mailing`. Expected behavior: - The SMS link should include the correct domain and the SMS code. odoo#201641
imanie383
force-pushed
the
16.0-sms-i3401-imanie383
branch
from
8f8310b to
f81866f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, the generated SMS link did not include the SMS code because it was created using the domain of the current website(second) instead of the intended one. This happened because the comparison was made against the
web.base.urlparameter instead of the current website domain.With this fix, the system correctly uses the current website domain for both link generation and comparison, ensuring the SMS code is applied.
Steps to reproduce:
mailing.mailingwith Concat Recipients.web.base.urlusing the same domain as the first website.mailing.mailing.CUrrent behavior:
Expected behavior:
Closes odoo#201641
Fixes odoo#201641
Screenshots
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr