[account_invoice_discount] Fixed to work with taxes included#668
Open
TheCloneMaster wants to merge 1 commit intoVauxoo:8.0from
TheCloneMaster:patch-1
Open
[account_invoice_discount] Fixed to work with taxes included#668TheCloneMaster wants to merge 1 commit intoVauxoo:8.0from TheCloneMaster:patch-1
TheCloneMaster wants to merge 1 commit intoVauxoo:8.0from
TheCloneMaster:patch-1
Conversation
Calculating amount_discount from totals gave incorrect amounts when a product had taxes included in price.
|
@TheCloneMaster we will review this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculating amount_discount from totals gave incorrect amounts when a product had taxes included in price.
Also, changed @api.multi to @api.one to be in line with _compute_amount methods on original account/account_invoice.py