Streak freeze - #126
Merged
Merged
Conversation
Unlimited freeze accumulation via add_freezes weakened the streak discipline mechanic. Reject additions that would push a user's balance above MAX_FREEZES (10) while leaving manual consumption (use_freeze) and the default starting balance untouched. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX_FREEZES(10) as the configurable maximum freeze balance instreaks/src/state.rsadd_freezesnow rejects (Error::InvalidAmount) any addition that would push a user's balance aboveMAX_FREEZES, instead of clamping or allowing unbounded growthuse_freeze) and the defaultINITIAL_FREEZES(3) are unchangedTest plan
cargo test -p streaks --test test_streaks— new tests cover exact-limit addition, over-limit rejection (by one and by a large amount), and manual consumption still working at the capcargo build -p streaks -p shared --all-targetsCloses #100