fix: harden Codex backend parity across runtime and validation#2
Closed
VasuBansal7576 wants to merge 1 commit intocodex/pr1-codex-adapterfrom
Closed
fix: harden Codex backend parity across runtime and validation#2VasuBansal7576 wants to merge 1 commit intocodex/pr1-codex-adapterfrom
VasuBansal7576 wants to merge 1 commit intocodex/pr1-codex-adapterfrom
Conversation
13 tasks
PR Closed - Requirements Not MetThis PR has been automatically closed because it doesn't meet the requirements. PR Author: @VasuBansal7576 To fix:
Exception: To bypass this requirement, you can:
Micro-fix requirements (must meet ALL):
Why is this required? See aden-hive#472 for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hardens the backend/runtime path that Codex was exposing more aggressively than other models. This PR focuses on validation, rerun/input propagation, worker handoff, result visibility at the event layer, stop behavior, and parity regression coverage.
Stacked on top of PR1: aden-hive#6830
Type of Change
Related Issues
Related to aden-hive#6741
Related to aden-hive#6817
Changes Made
Testing
Ran the following tests locally:
...................................ss......s............................ [ 28%]
........................................................................ [ 56%]
........................................................................ [ 85%]
..................................... [100%]
=============================== warnings summary ===============================
tests/test_codex_parity_gate.py: 1 warning
tests/test_validate_agent_path.py: 5 warnings
framework/server/tests/test_api.py: 82 warnings
/Users/vasu/Desktop/hive-upstream-prs/core/framework/server/app.py:240: NotAppKeyWarning: It is recommended to use web.AppKey instances for keys.
https://docs.aiohttp.org/en/stable/web_advanced.html#application-s-config
app["credential_store"] = credential_store
tests/test_codex_parity_gate.py: 1 warning
tests/test_validate_agent_path.py: 5 warnings
framework/server/tests/test_api.py: 82 warnings
/Users/vasu/Desktop/hive-upstream-prs/core/framework/server/app.py:241: NotAppKeyWarning: It is recommended to use web.AppKey instances for keys.
https://docs.aiohttp.org/en/stable/web_advanced.html#application-s-config
app["manager"] = SessionManager(model=model, credential_store=credential_store)
tests/test_validate_agent_path.py::TestHTTPEndpointsRejectMaliciousPaths::test_load_worker_rejects_outside_path
/Users/vasu/.local/share/uv/python/cpython-3.11.14-macos-aarch64-none/lib/python3.11/asyncio/base_events.py:1921: RuntimeWarning: coroutine 'ResponsesToCompletionBridgeHandler.acompletion' was never awaited
handle = self._ready.popleft()
Enable tracemalloc to get traceback where the object was allocated.
See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.
tests/test_validate_agent_path.py::TestHTTPEndpointsRejectMaliciousPaths::test_load_worker_rejects_outside_path
/Users/vasu/.local/share/uv/python/cpython-3.11.14-macos-aarch64-none/lib/python3.11/concurrent/futures/thread.py:85: RuntimeWarning: coroutine 'ResponsesToCompletionBridgeHandler.acompletion' was never awaited
del work_item
Enable tracemalloc to get traceback where the object was allocated.
See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.
framework/server/tests/test_api.py::TestCredentials::test_list_credentials_empty
framework/server/tests/test_api.py::TestCredentials::test_save_and_list_credential
framework/server/tests/test_api.py::TestCredentials::test_get_credential
framework/server/tests/test_api.py::TestCredentials::test_get_credential_not_found
framework/server/tests/test_api.py::TestCredentials::test_delete_credential
framework/server/tests/test_api.py::TestCredentials::test_delete_credential_not_found
framework/server/tests/test_api.py::TestCredentials::test_save_credential_missing_fields
framework/server/tests/test_api.py::TestCredentials::test_save_overwrites_existing
/Users/vasu/Desktop/hive-upstream-prs/core/framework/server/tests/test_api.py:1690: NotAppKeyWarning: It is recommended to use web.AppKey instances for keys.
https://docs.aiohttp.org/en/stable/web_advanced.html#application-s-config
app["credential_store"] = CredentialStore.for_testing(initial_creds or {})
framework/server/tests/test_api.py::TestErrorMiddleware::test_404_on_unknown_api_route
/Users/vasu/Desktop/hive-upstream-prs/.venv/lib/python3.11/site-packages/aiohttp/web_protocol.py:528: DeprecationWarning: returning HTTPException object is deprecated (aden-hive#2415) and will be removed, please raise the exception instead
warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
250 passed, 3 skipped, 187 warnings in 41.16s
Checklist
Screenshots (if applicable)
N/A